Add all proposed Keyboard shortcuts #451
Conversation
|
Preview PR at appsharing.space |
|
Integration tests repot: appsharing.space |
packages/base/src/keybindings.json
Outdated
| { | ||
| "command": "jupytercad:newCylinder", | ||
| "keys": ["Accel Alt C"], | ||
| "selector": ".jcad-Mainview" | ||
| }, | ||
| { | ||
| "command": "jupytercad:newCylinder", | ||
| "keys": ["Accel Alt C"], | ||
| "selector": ".jpcad-sidepanel-widget" | ||
| }, |
There was a problem hiding this comment.
I wonder if we should introduce a data attribute in our components that should receive keybinding events, like data-jcad-keybinding or something. Then we could get rid of this duplication and just do something like:
{
"command": "jupytercad:newCylinder",
"keys": ["Accel Alt C"],
"selector": "[data-jcad-keybinding]"
}
There was a problem hiding this comment.
I can try on it, thanks for suggesting.
There was a problem hiding this comment.
This worked, thanks @martinRenou.
Done in 2ddc2ed
There was a problem hiding this comment.
Ah I meant using a data attribute, not a class, have you tried that? But a general purpose class like you did sounds good too.
There was a problem hiding this comment.
Oh sorry, I guess I misinterpreted the idea. I'd be happy to explore this option too if it's more viable.
Might be silly but I'd just want to confirm how do I add data attribute to the component?
Should close #396
Should also close #458
Trust me! I'm pressing the keybinding while being on the the notebook 😇
keys.mov